Repository navigation
ci(release): pass GITHUB_ACTIONS to the release-gate mutation sandbox - #29
Merged
Merged
Conversation
The Release gate on main at 928d17c (run 37584264022) planned 2 mutants in one shard, then shard 1/1 failed: stryker exited 3 with "shard child for ../packages/starter failed with exit code 2: exit 2 (ConfigError): mutation runs only on main CI". stryker-js 17.0.2 admits a mutation run only when GITHUB_ACTIONS is "true", ALLOW_LOCAL_MUTATION is "1", or the run is dry-run only (src/refuse-local-mutation.workflow.ts). The sandbox clears the environment and the step passed only MUTATION_SHARD, so the flag GitHub sets on the runner never reached stryker The step now passes GITHUB_ACTIONS through as well. The planner test moves to sandbox-proofs/release-gate.test.ts and gains a case that runs the mutation step's command and pass-env list from release-gate.yml through sandbox, with a stand-in for node_modules/.bin/stryker that records the environment it receives, and requires GITHUB_ACTIONS=true and the shard. stryker itself is never run by the test As a sabotage proof, with main's release-gate.yml the new case fails with stryker saw "GITHUB_ACTIONS=\nMUTATION_SHARD=1/1\n", the same missing flag as the CI log CONST-W3: release-gate.yml is an evaluator surface (AGENTS.md Boundaries, CONST-E9), and the test is a new check. Both are changed on the explicit ruling of their owner (Kiro) to fix forward a red Release gate, not on the maker's own judgment
systemfsoftware-maker
added a commit
that referenced
this pull request
Oct 7, 2026
systemfsoftware-maker
added a commit
that referenced
this pull request
Oct 7, 2026
…s into the upstream subtree layer Brings #14's 42d0000 (dprint excludes the manifest-listed upstream tests only, checked by scripts/dprint-upstream-excludes.test.ts) and its merge of main's #29 and #30. turbo.json's test:scripts inputs keep both sides: this layer's subtrees.toml and repos/xstate-upstream/** and the packages layer's dprint.json, manifests and package test files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the second red Release gate on main, at
928d17c1(#28's squash). #28 fixed the planner: run 37584264022'splan · mutation shardsjob passed. The next step failed.Root cause
Run 37584264022, job
mutation · shard 1/1(112672895003), step "Mutation at break 100":stryker-js 17.0.2's refuse-local-mutation decision (
src/refuse-local-mutation.workflow.ts; in the installed dist,run-stages-*.mjsdecideandguardOf) admits a mutation run in only three cases:GITHUB_ACTIONSis"true";ALLOW_LOCAL_MUTATIONis"1";The step ran stryker through
./.github/actions/sandbox, which clears the environment, withpass-env: MUTATION_SHARD. The runner'sGITHUB_ACTIONS=truenever reached stryker. The planner passed becausestryker planis not a mutation run.Change
release-gate.yml: the mutation step'spass-envnow listsGITHUB_ACTIONSandMUTATION_SHARD.sandbox-proofs/release-gate-planner.test.tsbecomessandbox-proofs/release-gate.test.ts. Both cases share one Schema decode ofrelease-gate.yml. The new case:stryker runstep: its command, hosts andpass-env;sandboxwith those flags, in a fixture wherenode_modules/.bin/strykeris a stand-in that records the environment it receives;GITHUB_ACTIONS=trueandMUTATION_SHARD=1/1.It runs in
test:sandbox, whichcheck:ciand the CI test leg run. stryker itself is never run by the test.Sabotage proof
With main's
release-gate.yml, the new case fails:This is the same missing flag as the CI log. With the fix it passes.
Local gates on
2fa84d89pnpm bootstrap0 ·format:check0 ·gate:tasks9/9 ·gate:dist2/2 ·test:sandbox5 passed (13 steps) · commitlint 0.Not proven here
The step is now known to clear the main-CI guard. What stryker does after that guard, inside this sandbox, has never run anywhere: the guard stopped every run so far. Mutation does not run locally and
workflow_dispatchreturns 403. So the first proof is the push-to-main Release gate after merge. If it fails at a later point, the fix goes forward in another PR to main.CONST-W3:
release-gate.ymlis an evaluator surface (AGENTS.md Boundaries, CONST-E9), and the test is a new check. Both are changed on the explicit ruling of their owner (Kiro) to fix forward a red Release gate, not on the maker's own judgment.